Skip to content

feat(review): add area and topic reviewer rosters and routing - #4863

Open
purp wants to merge 15 commits into
NVIDIA:mainfrom
purp:docs/4839-reviewer-registry/purp
Open

purp wants to merge 15 commits into
NVIDIA:mainfrom
purp:docs/4839-reviewer-registry/purp

Conversation

@purp

@purp purp commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Add an area/topic reviewer roster and automatically request the matching reviewers when a PR becomes ready for review or its classification changes. Membership changes use reviewed PRs to REVIEWERS.md.

Draft for early feedback before broader community review. Please review the category scopes, suggested memberships, and routing behavior; initial nominations need the participants' agreement before merge.

Related Issue

Related to #4839. Subscription delivery and maintainer-coverage tracking remain follow-up work.

Changes

  • Protect REVIEWERS.md, the routing helper, and its tests with the existing maintainer CODEOWNERS rule; the workflow is already covered by directory ownership.
  • Add REVIEWERS.md with 23 areas/topics, 73 memberships, and 16 people, using the same three-column tables as MAINTAINERS.md.
  • Add importable parsing and planning helpers plus a preview/apply CLI. Request all matching members with current write access, deduplicate requests, and exclude the author. Preserve manual reviewer choices and anyone who has commented or reviewed, using current PR metadata without persisted state.
  • Add a workflow for ready PR creation, leaving draft, and area/topic label additions or removals. Use the trusted merged roster/helper and serialize runs per PR.
  • Document routing and roster changes in CONTRIBUTING.md. The existing maintainer-approval requirement continues to apply.

Testing

  • 29 focused offline tests pass.

  • The actual roster parses as 23 categories, 73 memberships, and 16 distinct people. All eight additions requested or nominated during review are present; existing memberships are preserved.

  • The workflow condition passes 10 trigger cases; whitespace checks pass.

  • Ruff, Actionlint, and Markdown lint could not be run because their downloads are blocked. No live review requests have been sent.

  • Checks appropriate to the affected code and behavior pass

  • Unit tests added/updated

  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

@copy-pr-bot

copy-pr-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

Comment thread .github/workflows/review-readiness.yml Dismissed
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
Comment thread REVIEWERS.md Resolved
@purp
purp marked this pull request as ready for review October 28, 2026 05:27
@purp
purp requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners October 28, 2026 05:27
Comment thread REVIEWERS.md Resolved
purp added 12 commits November 2, 2026 08:14
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@purp
purp force-pushed the docs/4839-reviewer-registry/purp branch from b3ca5d1 to 4ba8387 Compare November 2, 2026 17:00
purp added 2 commits November 2, 2026 09:42
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants